fix: Exclude Base64 images from image worker handling #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pecoram
changed the title
pecoram
changed the title
Contributor
|
I think we should skip the image worker entirely if we know its a |
Contributor
Author
|
I agree! What do others think? in that case should we leave XMLHttpRequest? on the ImageTexture we use fetch |
Contributor
|
There's already a fetch function if you skip the image worker, it will automatically fallback to fetch which should work out of the box: as far as I can see extending that if condition with a startsWith should do it? |
pecoram
changed the title
pecoram
changed the title
wouterlucas
requested changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Chrome versions before 67, data: URLs were treated as uncertain-origin resources for security reasons. In this context:
XMLHttpRequest did not allow access to base64 (data:) URLs because it violated CORS (Cross-Origin Resource Sharing) policies. Even though a data: URL is "local," it was still considered a different origin from the domain where the request was made.